nealrichardson commented on a change in pull request #10052:
URL: https://github.com/apache/arrow/pull/10052#discussion_r614162265



##########
File path: r/configure
##########
@@ -148,7 +148,7 @@ else
       if [ "$UNAME" = "Darwin" ] && [ "${OPENSSL_ROOT_DIR}" = "" ]; then
         brew --prefix openssl >/dev/null 2>&1
         if [ $? -eq 0 ]; then
-          export OPENSSL_ROOT_DIR="$(brew --prefix openssl)"
+          OPENSSL_ROOT_DIR="$(brew --prefix openssl)"; export OPENSSL_ROOT_DIR

Review comment:
       (insert BDR quote about how `$()` was a completely unnecessary change in 
bash)
   
   ```suggestion
             OPENSSL_ROOT_DIR="`brew --prefix openssl`"; export OPENSSL_ROOT_DIR
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to