raulcd commented on code in PR #47466:
URL: https://github.com/apache/arrow/pull/47466#discussion_r2316113887
##########
cpp/src/parquet/statistics.cc:
##########
@@ -991,6 +996,8 @@ std::shared_ptr<Comparator> DoMakeComparator(Type::type
physical_type,
default:
ParquetException::NYI("Unsigned Compare not implemented");
}
+ } else if (SortOrder::UNKNOWN == sort_order) {
+ return nullptr;
Review Comment:
This does not seem right because we were previously returning an Exception.
The problem is that if `ApplicationVersion::HasCorrectStatistics` returns true
when `SortOrder::UNKNOWN` if we want to generate the Typed Statistics a call to
`DoMakeComparator` is expected to return and not raise an Exception as is
currently happening.
Apart from ideas on what could be the best approach about that, this open
the question of the writer too. Should we also write Statistics for columns
with `SortOrder::UNKNOWN` but not compute min/max? Maybe as a different issue
is it worth it?
@pitrou what are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
