lidavidm commented on issue #835: URL: https://github.com/apache/arrow-java/issues/835#issuecomment-3248178198
That flamegraph seems to be cut off - can you show a screenshot that includes the Arrow frames? (I'm assuming that `readBytes` at the bottom is from https://github.com/apache/arrow-java/blob/156b465f7836dec3c3a109dbc101ee7270009ff7/flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/GetReadableBuffer.java#L91 ? ) That said I think this copy is likely unavoidable - we need a contiguous buffer and gRPC doesn't necessarily give it to us. We'd only be able to avoid it if it was actually a single buffer underneath that gRPC isn't giving to us already for some reason. (And from a quick glance through the code, I don't think the gRPC code is doing this optimization for us, if it even applies - as I recall, grpc-cpp has a similar issue and it's rare that gRPC actually only has a single buffer; something about their network stack tends to give a a set of smaller buffers that must be reassembled.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
