pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319494732


##########
cpp/src/arrow/util/rle_encoding_internal.h:
##########
@@ -118,50 +365,56 @@ class RleDecoder {
   /// input with zeros. Since the encoding does not differentiate between
   /// input values and padding, Get() returns true even for these padding
   /// values.
-  template <typename T>
-  bool Get(T* val);
+  [[nodiscard]] bool Get(value_type* val);

Review Comment:
   I'm curious, is this method actually used somewhere? It sounds unexpected to 
decode data one value at a time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to