lidavidm commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320447141
##########
docs/source/glossary.rst:
##########
@@ -46,15 +46,22 @@ Glossary
protocol, but exposes the JDBC client API instead.
driver manager
- A library that helps manage multiple drivers for a given client API.
- For example, the JDBC driver manager can find a appropriate driver
- implementation for a database URI.
+ A library for loading and using :term:`drivers <driver>`. A :term:`driver
+ manager` implements the ADBC API and delegates to dynamically-loaded
Review Comment:
Same here, no need to link driver manager to itself
##########
docs/source/python/driver_manager.rst:
##########
@@ -21,15 +21,11 @@
Driver Manager
==============
-The driver manager is a library that provides bindings to the ADBC C
-API. It delegates to dynamically-loaded drivers. This allows
-applications to use multiple drivers simultaneously, and decouple
-themselves from the specific driver.
+The ``adbc_driver_manager`` package provides a :term:`driver manager` interface
+for Python. The package provides two APIs:
-The Python driver manager provides both low-level bindings that are
-essentially the same as the C API. If PyArrow is installed, it also
-provides high-level bindings that implement the DBAPI_ (PEP 249)
-standard.
+1. Low-level bindings that are essentially the same as the :doc:`C API
<../format/specification>`.
+2. If PyArrow is installed, a DBAPI_ (PEP 249) compliant interface.
Review Comment:
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
