mbrobbel commented on code in PR #8251:
URL: https://github.com/apache/arrow-rs/pull/8251#discussion_r2324994127
##########
parquet/src/thrift.rs:
##########
@@ -33,12 +33,18 @@ pub trait TSerializable: Sized {
fn write_to_out_protocol<T: TOutputProtocol>(&self, o_prot: &mut T) ->
thrift::Result<()>;
}
-/// Public function to aid benchmarking.
+/// Public function to aid benchmarking. Reads Parquet `FileMetaData` encoded
in `bytes`.
pub fn bench_file_metadata(bytes: &bytes::Bytes) {
let mut input = TCompactSliceInputProtocol::new(bytes);
crate::format::FileMetaData::read_from_in_protocol(&mut input).unwrap();
}
+/// Public function to aid benchmarking. Reads Parquet `PageHeader` encoded in
`bytes`.
+pub fn bench_page_header(bytes: &bytes::Bytes) {
Review Comment:
Maybe we can put these functions behind a feature flag and/or add
`#[doc(hidden)]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
