kylebarron commented on code in PR #8286:
URL: https://github.com/apache/arrow-rs/pull/8286#discussion_r2325530169


##########
arrow-pyarrow-integration-testing/src/lib.rs:
##########
@@ -41,7 +41,7 @@ fn to_py_err(err: ArrowError) -> PyErr {
 
 /// Returns `array + array` of an int64 array.
 #[pyfunction]
-fn double(array: &Bound<PyAny>, py: Python) -> PyResult<PyObject> {
+fn double(array: &Bound<PyAny>, py: Python) -> PyResult<Py<PyAny>> {

Review Comment:
   It may make sense to change the return type of the `to_pyarrow` functions to 
`Bound<PyAny>` instead of `Py<PyAny>`? Then you wouldn't need to carry around a 
`py: Python` token in any of these functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to