JesseLovelace commented on code in PR #47503:
URL: https://github.com/apache/arrow/pull/47503#discussion_r2326047871
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3159,28 +2101,36 @@ macro(build_absl)
# -e 's/absl_/absl::/g' \
# -e 's/$/)/' | \
# grep -v 'INTERFACE_LINK_LIBRARIES[ ]*)'
- set_property(TARGET absl::algorithm PROPERTY INTERFACE_LINK_LIBRARIES
absl::config)
+ set_property(TARGET absl::absl_check PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::log_internal_check_impl)
+ set_property(TARGET absl::absl_log PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::log_internal_log_impl)
+ set_property(TARGET absl::absl_vlog_is_on
+ PROPERTY INTERFACE_LINK_LIBRARIES
+ absl::vlog_config_internal
+ absl::config
+ absl::core_headers
+ absl::strings)
set_property(TARGET absl::algorithm_container
- PROPERTY INTERFACE_LINK_LIBRARIES absl::algorithm
absl::core_headers
- absl::meta)
- set_property(TARGET absl::any
PROPERTY INTERFACE_LINK_LIBRARIES
- absl::bad_any_cast
+ absl::algorithm
+ absl::config
+ absl::core_headers
+ absl::meta
+ absl::nullability)
+ set_property(TARGET absl::algorithm PROPERTY INTERFACE_LINK_LIBRARIES
absl::config)
+ set_property(TARGET absl::any_invocable
+ PROPERTY INTERFACE_LINK_LIBRARIES
absl::config
absl::core_headers
- absl::fast_type_id
absl::type_traits
absl::utility)
+ set_property(TARGET absl::any PROPERTY INTERFACE_LINK_LIBRARIES absl::config
+ absl::core_headers absl::utility)
set_property(TARGET absl::atomic_hook PROPERTY INTERFACE_LINK_LIBRARIES
absl::config
absl::core_headers)
- set_property(TARGET absl::bad_any_cast PROPERTY INTERFACE_LINK_LIBRARIES
- absl::bad_any_cast_impl
absl::config)
- set_property(TARGET absl::bad_any_cast_impl
- PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
- set_property(TARGET absl::bad_optional_access
- PROPERTY INTERFACE_LINK_LIBRARIES absl::config
absl::raw_logging_internal)
Review Comment:
bad_optional_access doesn't exist in this updated version of absl, but it
looks like I missed removing the declaration of it even though I removed this
link libraries. Not sure if the script didn't catch it or if I made a mistake,
but I'll fully remove it, hopefully that fixes the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
