alamb commented on code in PR #8065:
URL: https://github.com/apache/arrow-rs/pull/8065#discussion_r2326714437
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -276,6 +276,10 @@ impl<T: ByteArrayType> GenericByteArray<T> {
}
/// Returns the element at index `i`
+ ///
+ /// Note: This method does not check for nulls and the value is arbitrary
+ /// if [`is_null`](Self::is_null) returns true for the index.
Review Comment:
> Here and in other places, is it guaranteed not to panic and return a valid
T::Native value corresponding to type T
Yes, to the best of my knowledge
> (in (theoretical?) case T::Native could represent some values not valid
for T)
Yes I think this is possible -- the only one I can think of now is
potentially date/time types where some valid integer is not a valid
date/time/timestamp instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
