raulcd commented on code in PR #47322:
URL: https://github.com/apache/arrow/pull/47322#discussion_r2321361820
##########
ci/scripts/python_sdist_test.sh:
##########
@@ -53,13 +53,17 @@ fi
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
+ sdist=$(echo "${arrow_dir}"/python/dist/pyarrow-*.tar.gz | sort -r | head
-n1)
fi
if [ -n "${ARROW_PYTHON_VENV:-}" ]; then
+ # We don't need to follow this external file.
+ # See also: https://www.shellcheck.net/wiki/SC1091
+ #
+ # shellcheck source=/dev/null
. "${ARROW_PYTHON_VENV}/bin/activate"
fi
-${PYTHON:-python} -m pip install ${sdist}
+${PYTHON:-python} -m pip install "${sdist}"
-pytest -r s ${PYTEST_ARGS:-} --pyargs pyarrow
+pytest -r s "${PYTEST_ARGS:-}" --pyargs pyarrow
Review Comment:
I had to revert this shellckeck change because somehow test collection
wasn't valid on pytest and it was going infinite collecting tests over the
system.
The following works
```
(arrow-dev) root@e4a18164297f:/# python -m pytest -r s --pyargs pyarrow
====================================================================================
test session starts
=====================================================================================
platform linux -- Python 3.10.12, pytest-8.4.1, pluggy-1.6.0
rootdir: /
plugins: hypothesis-6.138.14
collected 8017 items / 3 skipped
arrow-dev/lib/python3.10/site-packages/pyarrow/tests/interchange/test_conversion.py
..........
```
the following fails, keeps collecting jobs for a bunch of libraries and it
timeouts:
```
(arrow-dev) root@e4a18164297f:/# python -m pytest -r s "" --pyargs pyarrow
====================================================================================
test session starts
=====================================================================================
platform linux -- Python 3.10.12, pytest-8.4.1, pluggy-1.6.0
rootdir: /
plugins: hypothesis-6.138.14
collecting 285745 items / 45 errors / 59 skipped
^collected 287647 items / 45 errors / 61
skipped
```
Example of job failures that just timeout:
https://github.com/ursacomputing/crossbow/actions/runs/17438766622/job/49515794658
I will fix this on my PR to drop Python 3.9 support:
- https://github.com/apache/arrow/pull/47478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
