jorisvandenbossche commented on code in PR #47478:
URL: https://github.com/apache/arrow/pull/47478#discussion_r2329539224
##########
.github/workflows/archery.yml:
##########
@@ -67,7 +67,7 @@ jobs:
- name: Setup Python
uses: actions/[email protected]
with:
- python-version: '3.9'
+ python-version: '3.10'
Review Comment:
FWIW I think we could bump those also directly to a higher version, to not
have to change this every time we drop a python version for pyarrow
##########
.github/workflows/python.yml:
##########
@@ -63,41 +63,41 @@ jobs:
matrix:
name:
- conda-python-docs
- - conda-python-3.10-nopandas
- - conda-python-3.9-pandas-1.1.3
- - conda-python-3.11-pandas-latest
- - conda-python-3.11-no-numpy
+ - conda-python-3.11-nopandas
+ - conda-python-3.10-pandas-1.3.4
+ - conda-python-3.12-pandas-latest
Review Comment:
```suggestion
- conda-python-3.13-pandas-latest
```
Maybe use python 3.13 for one of the builds?
##########
docs/source/python/install.rst:
##########
@@ -27,7 +27,7 @@ Linux distributions. We strongly recommend using a 64-bit
system.
Python Compatibility
--------------------
-PyArrow is currently compatible with Python 3.9, 3.10, 3.11, 3.12 and 3.13.
+PyArrow is currently compatible with Python 3.10, 3.11, 3.12 and 3.13.
Review Comment:
A bit lower down in this file, there is a listing of the optional
dependencies and the minimal versions we support. That could be updated?
##########
dev/tasks/tasks.yml:
##########
@@ -1119,12 +1118,12 @@ tasks:
############################## Integration tests ############################
-{% for python_version, pandas_version, numpy_version, cache_leaf in [("3.9",
"1.1.3", "1.19.5", True),
- ("3.10",
"latest", "latest", False),
- ("3.11",
"latest", "1.26", False),
+{% for python_version, pandas_version, numpy_version, cache_leaf in [("3.10",
"1.3.4", "1.21.2", True),
("3.11",
"latest", "latest", False),
- ("3.11",
"nightly", "nightly", False),
- ("3.11",
"upstream_devel", "nightly", False)] %}
+ ("3.12",
"latest", "1.26", False),
+ ("3.12",
"latest", "latest", False),
+ ("3.12",
"nightly", "nightly", False),
+ ("3.12",
"upstream_devel", "nightly", False)] %}
Review Comment:
```suggestion
("3.13", "nightly", "nightly", False),
("3.13", "upstream_devel", "nightly", False)] %}
```
(doesn't have to be done here, but varying the python version a bit more
seems useful)
##########
.github/workflows/python.yml:
##########
@@ -63,41 +63,41 @@ jobs:
matrix:
name:
- conda-python-docs
- - conda-python-3.10-nopandas
- - conda-python-3.9-pandas-1.1.3
- - conda-python-3.11-pandas-latest
- - conda-python-3.11-no-numpy
+ - conda-python-3.11-nopandas
+ - conda-python-3.10-pandas-1.3.4
+ - conda-python-3.12-pandas-latest
+ - conda-python-3.12-no-numpy
include:
- name: conda-python-docs
cache: conda-python-3.10
image: conda-python-docs
title: AMD64 Conda Python 3.10 Sphinx & Numpydoc
python: "3.10"
- - name: conda-python-3.10-nopandas
- cache: conda-python-3.10
+ - name: conda-python-3.11-nopandas
+ cache: conda-python-3.11
image: conda-python
- title: AMD64 Conda Python 3.10 Without Pandas
- python: "3.10"
- - name: conda-python-3.9-pandas-1.1.3
- cache: conda-python-3.9
+ title: AMD64 Conda Python 3.11 Without Pandas
+ python: "3.11"
+ - name: conda-python-3.10-pandas-1.3.4
+ cache: conda-python-3.10
image: conda-python-pandas
- title: AMD64 Conda Python 3.9 Pandas 1.1.3
- python: 3.9
- pandas: "1.1.3"
- numpy: 1.19.5
- - name: conda-python-3.11-pandas-latest
- cache: conda-python-3.11
+ title: AMD64 Conda Python 3.10 Pandas 1.3.4
+ python: "3.10"
+ pandas: "1.3.4"
+ numpy: "1.21.2"
Review Comment:
I would certainly keep this job with the lower bound versions (otherwise it
is hard to claim we support running with those minimal versions).
The above seems fine for here. I think we could also bump the minimum
numpy/pandas versions higher, but that could maybe be done separately (since it
is not related to dropping Python 3.9 support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
