jasonlin45 commented on code in PR #3325: URL: https://github.com/apache/arrow-adbc/pull/3325#discussion_r2330687432
########## go/adbc/driver/databricks/database.go: ########## @@ -0,0 +1,406 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package databricks + +import ( + "context" + "database/sql" + "fmt" + "strconv" + "strings" + "time" + + "crypto/tls" + "crypto/x509" + "net/http" + "os" + + "github.com/apache/arrow-adbc/go/adbc" + "github.com/apache/arrow-adbc/go/adbc/driver/internal/driverbase" + dbsql "github.com/databricks/databricks-sql-go" +) + +const DEFAULT_PORT = 443 +const DEFAULT_RETRY_WAIT_MIN = 1 * time.Second +const DEFAULT_RETRY_WAIT_MAX = 30 * time.Second + +type databaseImpl struct { + driverbase.DatabaseImplBase + + // Connection Pool + db *sql.DB + needsRefresh bool // Whether we need to re-initialize + + // Connection parameters + serverHostname string + httpPath string + accessToken string + port string + catalog string + schema string + + // Query options + queryTimeout time.Duration + maxRows int + queryRetryCount int + downloadThreadCount int + + // TLS/SSL options + sslMode string + sslRootCert string + + // OAuth options (for future expansion) + oauthClientID string + oauthClientSecret string + oauthRefreshToken string +} + +func (d *databaseImpl) resolveConnectionOptions() ([]dbsql.ConnOption, error) { + if d.serverHostname == "" { + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: "server hostname is required", + } + } + + if d.httpPath == "" { + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: "HTTP path is required", + } + } + + // FIXME: Support other auth methods + if d.accessToken == "" { + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: "access token is required", + } + } + + opts := []dbsql.ConnOption{ + dbsql.WithAccessToken(d.accessToken), + dbsql.WithServerHostname(d.serverHostname), + dbsql.WithHTTPPath(d.httpPath), + } + + // Validate and set custom port + // Defaults to 443 + if d.port != "" { + port, err := strconv.Atoi(d.port) + if err != nil || port < 1 || port > 65535 { + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: "invalid port number", + } + } + opts = append(opts, dbsql.WithPort(port)) + } else { + opts = append(opts, dbsql.WithPort(DEFAULT_PORT)) + } + + // Default namespace for queries (catalog/schema) + if d.catalog != "" || d.schema != "" { + opts = append(opts, dbsql.WithInitialNamespace(d.catalog, d.schema)) + } + + if d.queryTimeout > 0 { + opts = append(opts, dbsql.WithTimeout(d.queryTimeout)) + } + + if d.maxRows > 0 { + opts = append(opts, dbsql.WithMaxRows(int(d.maxRows))) + } + if d.queryRetryCount >= 0 { + opts = append(opts, dbsql.WithRetries(d.queryRetryCount, DEFAULT_RETRY_WAIT_MIN, DEFAULT_RETRY_WAIT_MAX)) + } + if d.downloadThreadCount > 0 { + opts = append(opts, dbsql.WithMaxDownloadThreads(d.downloadThreadCount)) + } + + // TLS/SSL handling + if d.sslMode != "" || d.sslRootCert != "" { + var tlsConfig *tls.Config + + // Handle custom root certificate + if d.sslRootCert != "" { + caCert, err := os.ReadFile(d.sslRootCert) + if err != nil { + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: fmt.Sprintf("failed to read SSL root certificate: %v", err), + } + } + + caCertPool := x509.NewCertPool() + if !caCertPool.AppendCertsFromPEM(caCert) { + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: "failed to parse SSL root certificate", + } + } + + tlsConfig = &tls.Config{ + RootCAs: caCertPool, + MinVersion: tls.VersionTLS12, + } + } + + // Handle SSL mode + if d.sslMode != "" { + switch strings.ToLower(d.sslMode) { + case "insecure": + if tlsConfig == nil { + tlsConfig = &tls.Config{MinVersion: tls.VersionTLS12} + } + tlsConfig.InsecureSkipVerify = true + case "require": + // Default behavior - full TLS verification + if tlsConfig == nil { + tlsConfig = &tls.Config{MinVersion: tls.VersionTLS12} + } + default: + return nil, adbc.Error{ + Code: adbc.StatusInvalidArgument, + Msg: fmt.Sprintf("invalid SSL mode: %s (supported: 'require', 'insecure')", d.sslMode), + } + } + } + + // Apply custom TLS config if we have one + if tlsConfig != nil { + transport := &http.Transport{ + TLSClientConfig: tlsConfig, + } + opts = append(opts, dbsql.WithTransport(transport)) + } + } + + return opts, nil +} + +func (d *databaseImpl) initializeConnectionPool(ctx context.Context) (*sql.DB, error) { + opts, err := d.resolveConnectionOptions() + + if err != nil { + return nil, err + } + + connector, err := dbsql.NewConnector(opts...) + + if err != nil { + return nil, err + } + + db := sql.OpenDB(connector) + + // Test the connection + if err := db.PingContext(ctx); err != nil { + _ = db.Close() // Ignore error on cleanup Review Comment: Yes - swallowing a leak is probably not a good idea. Fixed in 08478ec88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
