jecsand838 commented on PR #8298: URL: https://github.com/apache/arrow-rs/pull/8298#issuecomment-3268289160
@nathaniel-d-ef Thanks for getting this up! I did a quick pre-review glance over and had two quick items: 1. We'll probably want to feature flag `Decimal32` and `Decimal64` using `small_decimals`. 2. I'd bring over the round trip integration tests for these new types in `arrow-avro/src/writer/mod.rs`. I know that makes the PR bigger, but it also verifies the functionality. You could always split this into two independent PRs if it get's too large, i.e. (Fixed, Decimal, Uuid, etc.) and (Map and Enum, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
