kou commented on code in PR #3417: URL: https://github.com/apache/arrow-adbc/pull/3417#discussion_r2331853378
########## LICENSE.txt: ########## @@ -1246,6 +1550,110 @@ github.com/klauspost/compress is under the Apache-2.0 license. -------------------------------------------------------------------------------- +3rdparty dependency github.com/klauspost/compress +is statically linked in certain binary distributions, like the Python wheels. +github.com/klauspost/compress is under the BSD-3-Clause license. Review Comment: They may be duplicated entries. ########## LICENSE.txt: ########## @@ -602,12 +602,6 @@ THE SOFTWARE. -------------------------------------------------------------------------------- -3rdparty dependency github.com/apache/arrow-go/v18 -is statically linked in certain binary distributions, like the Python wheels. -github.com/apache/arrow-go/v18 is under the Apache-2.0 license. - --------------------------------------------------------------------------------- - 3rdparty dependency github.com/apache/thrift/lib/go/thrift is statically linked in certain binary distributions, like the Python wheels. github.com/apache/thrift/lib/go/thrift is under the Apache-2.0 license. Review Comment: We can remove this because apache/thrift is an ASF project: https://infra.apache.org/licensing-howto.html#bundle-asf-product ########## LICENSE.txt: ########## @@ -1238,6 +1232,316 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. +-------------------------------------------------------------------------------- + +3rdparty dependency github.com/klauspost/compress +is statically linked in certain binary distributions, like the Python wheels. +github.com/klauspost/compress is under the MIT license. +Copyright (c) 2012 The Go Authors. All rights reserved. +Copyright (c) 2019 Klaus Post. All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are +met: + + * Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. + * Redistributions in binary form must reproduce the above +copyright notice, this list of conditions and the following disclaimer +in the documentation and/or other materials provided with the +distribution. + * Neither the name of Google Inc. nor the names of its +contributors may be used to endorse or promote products derived from +this software without specific prior written permission. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +------------------ + +Files: gzhttp/* Review Comment: Is this path correct? https://github.com/apache/arrow-adbc/tree/main doesn't have the path. ########## LICENSE.txt: ########## @@ -1238,6 +1232,316 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. +-------------------------------------------------------------------------------- + +3rdparty dependency github.com/klauspost/compress +is statically linked in certain binary distributions, like the Python wheels. +github.com/klauspost/compress is under the MIT license. Review Comment: It seems that this is also appeared in later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org