kou commented on code in PR #47282:
URL: https://github.com/apache/arrow/pull/47282#discussion_r2335216822
##########
cpp/src/arrow/meson.build:
##########
@@ -420,19 +481,38 @@ foreach key, val : arrow_components
arrow_deps += val.get('dependencies', [])
endforeach
+arrow_lib_cpp_shared_args = ['-DARROW_EXPORTING', '-DURI_LIBRARY_BUILD']
+if needs_compute
+ arrow_lib_cpp_shared_args += ['-DARROW_COMPUTE_EXPORTING']
+endif
+
arrow_lib = library(
'arrow',
sources: arrow_srcs,
include_directories: arrow_includes,
dependencies: arrow_deps,
install: true,
gnu_symbol_visibility: 'inlineshidden',
- cpp_shared_args: ['-DARROW_EXPORTING'],
+ gnu_symbol_visibility: 'hidden',
+ c_shared_args: [
+ '-DARROW_EXPORTING',
+ '-DURI_LIBRARY_BUILD',
+ '-DURI_VISIBILITY',
Review Comment:
Hmm. It seems that this C++ source
https://github.com/apache/arrow/blob/417df286dfaf0a20280684fd0093e5fac589e42b/cpp/src/arrow/util/uri.cc#L28
also uses it.
BTW, why do we need to use `-DURI_LIBRARY_BUILD`? CMake uses
`URI_STATIC_BUILD` because vendored/uriparser is built into `libarrow`:
https://github.com/apache/arrow/blob/417df286dfaf0a20280684fd0093e5fac589e42b/cpp/src/arrow/CMakeLists.txt#L478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
