birschick-bq commented on code in PR #3397:
URL: https://github.com/apache/arrow-adbc/pull/3397#discussion_r2338079886
##########
csharp/test/Telemetry/Traces/Exporters/FileExporter/FileExporterTests.cs:
##########
@@ -252,12 +252,23 @@ internal async Task CanTraceMultipleConcurrentWriters()
if (Directory.Exists(traceFolder)) Directory.Delete(traceFolder,
true);
try
{
+ TracerProvider provider1 = Sdk.CreateTracerProviderBuilder()
+ .AddSource(_activitySourceName)
+ .AddAdbcFileExporter(_activitySourceName, traceFolder)
+ .Build();
+ TracerProvider provider2 = Sdk.CreateTracerProviderBuilder()
+ .AddSource(_activitySourceName)
+ .AddAdbcFileExporter(_activitySourceName, traceFolder)
+ .Build();
var tasks = new Task[]
{
- Task.Run(async () => await TraceActivities(traceFolder,
"activity1", writeCount)),
- Task.Run(async () => await TraceActivities(traceFolder,
"activity2", writeCount)),
+ Task.Run(async () => await TraceActivities(traceFolder,
"activity1", writeCount, provider1)),
+ Task.Run(async () => await TraceActivities(traceFolder,
"activity2", writeCount, provider1)),
Review Comment:
Added comment on intent of having 2 providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
