wgtmac commented on code in PR #47524:
URL: https://github.com/apache/arrow/pull/47524#discussion_r2343308108


##########
cpp/src/arrow/csv/options.h:
##########
@@ -188,6 +188,12 @@ struct ARROW_EXPORT WriteOptions {
   /// Whether to write an initial header line with column names
   bool include_header = true;
 
+  /// \brief Quoting style of header
+  ///
+  /// If `quoting_header` is `QuotingStyle::None`, then only write quotes when 
a column
+  /// name contains structural characters. Otherwise, always quote column 
names.
+  QuotingStyle quoting_header = QuotingStyle::AllValid;

Review Comment:
   I would recommend keeping the same semantics for both header and data. So in 
short:
   - `None` will never add quotes and throw for control characters.
   - `Needed` and `AllValid` always add quotes except for null, as we regard 
all header fields as string types. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to