jecsand838 commented on code in PR #8316:
URL: https://github.com/apache/arrow-rs/pull/8316#discussion_r2345244784
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -70,25 +107,101 @@
//! if buffered.is_empty() {
//! buffered = match ready!(input.poll_next_unpin(cx)) {
//! Some(b) => b,
-//! None => break,
+//! None => break, // EOF
//! };
//! }
+//! // Feed as much as possible
//! let decoded = match decoder.decode(buffered.as_ref()) {
-//! Ok(decoded) => decoded,
+//! Ok(n) => n,
//! Err(e) => return Poll::Ready(Some(Err(e))),
//! };
//! let read = buffered.len();
//! buffered.advance(decoded);
//! if decoded != read {
+//! // decoder made partial progress; request more bytes
//! break
//! }
//! }
-//! // Convert any fully-decoded rows to a RecordBatch, if available
+//! // Return a batch if one or more rows are complete
//! Poll::Ready(decoder.flush().transpose())
//! })
//! }
//! ```
//!
+//! ### Building a `Decoder` for **single‑object encoding** (Rabin
fingerprints)
Review Comment:
That's a good point. I'll add a link to the spec here to enhance clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
