kou commented on code in PR #47546:
URL: https://github.com/apache/arrow/pull/47546#discussion_r2345450536
##########
.github/workflows/cpp_extra.yml:
##########
@@ -278,3 +278,59 @@ jobs:
cmake --build cpp/examples/minimal_build.build
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+
+ report-extra-cpp:
+ runs-on: ubuntu-latest
+ needs:
+ - docker
+ - jni-macos
+ # We don't have the job id as part of the context neither the job name.
+ # The GitHub API exposes numeric id or job name but not the github.job
(report-extra-cpp).
+ # We match github.job to the name so we can pass it via context in order
to be ignored on the report.
+ # The job is still running.
+ name: ${{ github.job }}
+ if: github.event_name == 'schedule' && always()
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Setup Python
+ uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #
v6.0.0
+ with:
+ python-version: 3
+ - name: Setup Archery
+ run: python3 -m pip install -e dev/archery[crossbow]
+ - name: Notify
+ env:
+ GH_TOKEN: ${{ github.token }}
+ CHAT_WEBHOOK: ${{ secrets.ARROW_ZULIP_WEBHOOK }}
+ SMTP_PASSWORD: ${{ secrets.ARROW_SMTP_PASSWORD }}
+ run: |
+ # Continue even if email sending fails
+ echo "Sending email report."
+ set +e
+ archery ci report-email \
+ --send \
+ --smtp-server 'commit-email.info' \
+ --sender-name Arrow \
+ --sender-email 'ar...@commit-email.info' \
+ --recipient-email 'bui...@arrow.apache.org' \
+ --smtp-user arrow \
+ --smtp-port 587 \
+ --ignore ${{ github.job }} \
+ --repository ${{ github.repository }} \
+ ${{ github.run_id }}
+ email_exit_code=$?
+ set -e
+
+ if [ $email_exit_code -ne 0 ]; then
+ echo "::warning::Email sending failed but continuing with workflow"
+ fi
Review Comment:
Or we can use separated steps with `if: always()`.
##########
.github/workflows/cpp_extra.yml:
##########
@@ -278,3 +278,59 @@ jobs:
cmake --build cpp/examples/minimal_build.build
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+
+ report-extra-cpp:
+ runs-on: ubuntu-latest
+ needs:
+ - docker
+ - jni-macos
+ # We don't have the job id as part of the context neither the job name.
+ # The GitHub API exposes numeric id or job name but not the github.job
(report-extra-cpp).
+ # We match github.job to the name so we can pass it via context in order
to be ignored on the report.
+ # The job is still running.
+ name: ${{ github.job }}
+ if: github.event_name == 'schedule' && always()
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Setup Python
+ uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #
v6.0.0
+ with:
+ python-version: 3
+ - name: Setup Archery
+ run: python3 -m pip install -e dev/archery[crossbow]
+ - name: Notify
+ env:
+ GH_TOKEN: ${{ github.token }}
+ CHAT_WEBHOOK: ${{ secrets.ARROW_ZULIP_WEBHOOK }}
+ SMTP_PASSWORD: ${{ secrets.ARROW_SMTP_PASSWORD }}
+ run: |
+ # Continue even if email sending fails
+ echo "Sending email report."
+ set +e
+ archery ci report-email \
+ --send \
+ --smtp-server 'commit-email.info' \
+ --sender-name Arrow \
+ --sender-email 'ar...@commit-email.info' \
+ --recipient-email 'bui...@arrow.apache.org' \
+ --smtp-user arrow \
+ --smtp-port 587 \
+ --ignore ${{ github.job }} \
+ --repository ${{ github.repository }} \
Review Comment:
Could you sort these arguments in alphabetical order?
##########
.github/workflows/cpp_extra.yml:
##########
@@ -278,3 +278,59 @@ jobs:
cmake --build cpp/examples/minimal_build.build
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+
+ report-extra-cpp:
+ runs-on: ubuntu-latest
+ needs:
+ - docker
+ - jni-macos
+ # We don't have the job id as part of the context neither the job name.
+ # The GitHub API exposes numeric id or job name but not the github.job
(report-extra-cpp).
+ # We match github.job to the name so we can pass it via context in order
to be ignored on the report.
+ # The job is still running.
+ name: ${{ github.job }}
+ if: github.event_name == 'schedule' && always()
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Setup Python
+ uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c #
v6.0.0
+ with:
+ python-version: 3
+ - name: Setup Archery
+ run: python3 -m pip install -e dev/archery[crossbow]
+ - name: Notify
+ env:
+ GH_TOKEN: ${{ github.token }}
+ CHAT_WEBHOOK: ${{ secrets.ARROW_ZULIP_WEBHOOK }}
+ SMTP_PASSWORD: ${{ secrets.ARROW_SMTP_PASSWORD }}
+ run: |
+ # Continue even if email sending fails
+ echo "Sending email report."
+ set +e
+ archery ci report-email \
+ --send \
+ --smtp-server 'commit-email.info' \
+ --sender-name Arrow \
+ --sender-email 'ar...@commit-email.info' \
+ --recipient-email 'bui...@arrow.apache.org' \
+ --smtp-user arrow \
+ --smtp-port 587 \
Review Comment:
NOTE: We can also use the default 465 (submissions, submission + SSL) port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
