alamb commented on code in PR #456: URL: https://github.com/apache/arrow-rs-object-store/pull/456#discussion_r2346578715
########## src/attributes.rs: ########## @@ -45,6 +45,14 @@ pub enum Attribute { /// /// See [Cache-Control](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control) CacheControl, + /// Specifies the storage class of the object. + /// + /// See [AWS](https://aws.amazon.com/s3/storage-classes/), + /// [GCP](https://cloud.google.com/storage/docs/storage-classes), and + /// [Azure](https://learn.microsoft.com/en-us/rest/api/storageservices/set-blob-tier). + /// `StorageClass` is used as the name for this attribute because 2 of the 3 storage providers + /// use that name + StorageClass, Review Comment: I verified that adding a new enum variant is not a breaking API change as this enum is marked `#[non_exhaustive]` ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org