codephage2020 commented on code in PR #8346:
URL: https://github.com/apache/arrow-rs/pull/8346#discussion_r2347753047
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -874,6 +891,52 @@ mod test {
f64
);
+ /// Return a VariantArray that represents a partially "shredded" variant
for bool
+ fn partially_shredded_bool_variant_array() -> ArrayRef {
+ let (metadata, string_value) = {
+ let mut builder = parquet_variant::VariantBuilder::new();
+ builder.append_value("n/a");
+ builder.finish()
+ };
+
+ let nulls = NullBuffer::from(vec![
+ true, // row 0 non null
+ false, // row 1 is null
+ true, // row 2 non null
+ true, // row 3 non null
+ ]);
+
+ // metadata is the same for all rows
+ let metadata =
BinaryViewArray::from_iter_values(std::iter::repeat_n(&metadata, 4));
+
+ // See
https://docs.google.com/document/d/1pw0AWoMQY3SjD7R4LgbPvMjG_xSCtXp3rZHkVp9jpZ4/edit?disco=AAABml8WQrY
+ // about why row1 is an empty but non null, value.
+ let values = BinaryViewArray::from(vec![
+ None, // row 0 is shredded, so no value
+ Some(b"" as &[u8]), // row 1 is null, so empty value (why?)
+ Some(&string_value), // copy the string value "N/A"
+ None, // row 3 is shredded, so no value
+ ]);
+
+ let typed_value = arrow::array::BooleanArray::from(vec![
+ Some(true), // row 0 is shredded, so it has a value
+ None, // row 1 is null, so no value
+ None, // row 2 is a string, so no typed value
+ Some(false), // row 3 is shredded, so it has a value
+ ]);
+
+ let struct_array = StructArrayBuilder::new()
+ .with_field("metadata", Arc::new(metadata))
Review Comment:
It's worth noting that Once this
[PR](https://github.com/apache/arrow-rs/pull/8342) is merged, it should be
rewritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
