Arkur745 commented on code in PR #47522:
URL: https://github.com/apache/arrow/pull/47522#discussion_r2348908852
##########
cpp/src/arrow/array/builder_nested.h:
##########
@@ -767,10 +767,15 @@ class ARROW_EXPORT StructBuilder : public ArrayBuilder {
/// be called independently to maintain data-structure consistency.
Status Append(bool is_valid = true) {
ARROW_RETURN_NOT_OK(Reserve(1));
- UnsafeAppendToBitmap(is_valid);
+ UnsafeAppend(is_valid);
return Status::OK();
}
+ /// This method is "unsafe" because it does not update the null bitmap.
Review Comment:
Initially, my approach was different. But that didn't work out. I will
remove this comment in my next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
