mbrobbel commented on PR #8227: URL: https://github.com/apache/arrow-rs/pull/8227#issuecomment-3293410283
> The only real concern I have is to ensure that this change remain backwards compatible with existing users / rust versions? Given the MSRV checks I think it will, but we might want to double check (maybe we can try to update DataFusion to use this PR to see) The 2024 edition is supported by rustc >=1.85 so with the msrv bump it should be fine. > 1. just change `rustfmt.toml` file to get the formatting only changes? I tried it locally and it didn't seem to change anything I reverted the formatting changes. It's now using 2021 edition for rustfmt. We can update in a different PR. > 2. Change the edition for only a few crates at a time (arrow, arrow-schema in one PR, then `parquet` in the next, etc) Let me know if you still want me to do this. > > BTW I think this PR is likely to attract many merge conflicts, so it probably makes sense to get it merged asap We have to wait until #7836. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
