emkornfield commented on a change in pull request #9964:
URL: https://github.com/apache/arrow/pull/9964#discussion_r614536974
##########
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDictionaryVector.java
##########
@@ -982,15 +981,15 @@ public void testDictionaryUIntOverflow() {
}
}
- private int[] convertListToIntArray(JsonStringArrayList list) {
+ private int[] convertListToIntArray(List list) {
int[] values = new int[list.size()];
for (int i = 0; i < list.size(); i++) {
values[i] = (int) list.get(i);
}
return values;
}
- private Object[] convertMapValuesToArray(JsonStringHashMap map) {
+ private Object[] convertMapValuesToArray(Map map) {
Review comment:
should this be Map<?, ?>?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
