alamb opened a new pull request, #8365: URL: https://github.com/apache/arrow-rs/pull/8365
# Which issue does this PR close? - closes https://github.com/apache/arrow-rs/issues/8296 - closes https://github.com/apache/arrow-rs/issues/8319 # Rationale for this change We need a way to write Variant encoded data to/from parquet, and the current way the VariantArray is implemented doesn't work (panics when writing to parquet) TODO: - [ ] examples for going to/from Array --> VariantArray based on the Field's metadata - [ ] Add the Field metadata based on the logical annotation from parquet # What changes are included in this PR? 1. remove the `Array` impl for `VariantArray`, which forces explict conversions back/forth when writing As a follow on PR I plan to give the same basic treatment to `ShreddedVariantStateArray` # Are these changes tested? yes, by existing tests and ndw tests # Are there any user-facing changes? Yes, but this is not yet stable / released, so these changes have no impact on the releasability of this code 1. `VariantArray` no longer implements `Array` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
