efd6 commented on code in PR #510:
URL: https://github.com/apache/arrow-go/pull/510#discussion_r2353638867
##########
arrow/array/timestamp.go:
##########
@@ -34,11 +34,16 @@ import (
type Timestamp struct {
array
values []arrow.Timestamp
+ format string
}
// NewTimestampData creates a new Timestamp from Data.
func NewTimestampData(data arrow.ArrayData) *Timestamp {
- a := &Timestamp{}
+ return NewTimestampDataWithFormat(data, time.RFC3339Nano)
+}
+
+func NewTimestampDataWithFormat(data arrow.ArrayData, format string)
*Timestamp {
Review Comment:
```suggestion
func NewTimestampDataWithLayout(data arrow.ArrayData, layout string)
*Timestamp {
```
reflecting the terminology used in stdlib/time (`s/format/layout/g`
throughout)
Also probably want godoc for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
