zeroshade commented on code in PR #505:
URL: https://github.com/apache/arrow-go/pull/505#discussion_r2353744845
##########
arrow/compute/internal/kernels/scalar_comparisons.go:
##########
@@ -589,7 +591,7 @@ func compareTimestampKernel(ty exec.InputType, op
CompareOperator) exec.ScalarKe
var (
boolEQ = binaryBoolOps{
arrArr: func(_ *exec.KernelCtx, lhs, rhs, out bitutil.Bitmap)
error {
- bitutil.BitmapAnd(lhs.Data, rhs.Data, lhs.Offset,
rhs.Offset, out.Data, out.Offset, out.Len)
+ bitutil.BitmapXnor(lhs.Data, rhs.Data, lhs.Offset,
rhs.Offset, out.Data, out.Offset, out.Len)
Review Comment:
Can you add a test to `scalar_comparisons_test.go` which tests Boolean
scalar equal? I'm assuming we must not have a test in there for this, otherwise
it would have been caught sooner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
