pitrou commented on code in PR #47524:
URL: https://github.com/apache/arrow/pull/47524#discussion_r2348954004
##########
cpp/src/arrow/csv/writer_test.cc:
##########
@@ -279,7 +290,20 @@ std::vector<WriterTestParams> GenerateTestCases() {
{schema_custom_delimiter, batch_custom_delimiter,
DefaultTestOptions(/*include_header=*/false, /*null_string=*/"",
QuotingStyle::Needed, /*eol=*/";",
/*delimiter=*/';'),
- /*expected_output*/ "", expected_status_illegal_delimiter(';')}};
+ /*expected_output*/ "", expected_status_illegal_delimiter(';')},
Review Comment:
It seems that all three `QuotingStyle` values should be tested with a mix of
column names requiring quoting and column names that don't need quoting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
