dsevilla commented on PR #47458: URL: https://github.com/apache/arrow/pull/47458#issuecomment-3307046484
Hello! > Thank you for proposing a fix! In principle the change looks ok to me. The comment did confuse me a bit (`Special case host = "default" or "hdfs://default" as stated by #25324.`). If I understand correctly this change is only dealing with host being `default` and not `hdfs://default` also? > I think the logic goes like this: - If the URI is `hdfs://default:0/...`, then, `uri.host()` is "default", and `uri.scheme()` is `hdfs`. - If the URI is `default:0/...`, then again `uri.host()` is still "default", but `uri.scheme()` is empty. Then, in either case, I leave the variable `host` (that will hold the host plus optional scheme and will be passed down to the library) as just `"default"`. This way libhdfs will see just `default:0/...`. If the host is not "default" in any case, the old behaviour (scheme://host:porg) is maintained. > I am not sure how to go about testing this. cc @pitrou I am not sure, either. I will investigate, but I remember a test for `HadoopFileSystem` using "default" as a host (that works as per the other previous patch). It can be added there. I'll search for it ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
