emkornfield commented on a change in pull request #9750:
URL: https://github.com/apache/arrow/pull/9750#discussion_r614922807
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -302,40 +302,41 @@ char* gdv_fn_dec_to_string(int64_t context, int64_t
x_high, uint64_t x_low,
return val;
\
}
-#define GDV_FN_TO_CHAR(IN_TYPE, ARROW_TYPE)
\
- GANDIVA_EXPORT
\
+#define GDV_FN_TO_CHAR(IN_TYPE, ARROW_TYPE)
\
Review comment:
there should be comments on these macros to describe what the function
does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
