pitrou commented on a change in pull request #9782:
URL: https://github.com/apache/arrow/pull/9782#discussion_r614981828
##########
File path: cpp/src/parquet/types.cc
##########
@@ -69,11 +69,6 @@ std::unique_ptr<Codec> GetCodec(Compression::type codec, int
compression_level)
throw ParquetException(ss.str());
}
- if (codec == Compression::LZ4) {
Review comment:
We're not deprecating anything, `Compression::LZ4` simply means "use the
LZ4 raw (block) format" as it was always meant to be. We're unable to reliably
produce Hadoop-readable files anywhere, it would be counter-productive to still
produce them by default.
##########
File path: cpp/src/parquet/types.cc
##########
@@ -69,11 +69,6 @@ std::unique_ptr<Codec> GetCodec(Compression::type codec, int
compression_level)
throw ParquetException(ss.str());
}
- if (codec == Compression::LZ4) {
Review comment:
We're not deprecating anything, `Compression::LZ4` simply means "use the
LZ4 raw (block) format" as it was always meant to be. We're unable to reliably
produce Hadoop-readable files anyway, it would be counter-productive to still
produce them by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
