alamb commented on code in PR #8345:
URL: https://github.com/apache/arrow-rs/pull/8345#discussion_r2348603310
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -27,87 +26,117 @@ use crate::VariantArrayBuilder;
use std::sync::Arc;
+/// Builder for converting variant values into strongly typed Arrow arrays.
+///
+/// Useful for variant_get kernels that need to extract specific paths from
variant values, possibly
+/// with casting of leaf values to specific types.
+pub(crate) enum VariantToArrowRowBuilder<'a> {
+ // Direct builders (no path extraction)
+ Int8(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Int8Type>),
+ Int16(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Int16Type>),
+ Int32(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Int32Type>),
+ Int64(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Int64Type>),
+ Float16(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Float16Type>),
+ Float32(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Float32Type>),
+ Float64(VariantToPrimitiveArrowRowBuilder<'a, datatypes::Float64Type>),
+ BinaryVariant(VariantToBinaryVariantArrowRowBuilder),
+
+ // Path extraction wrapper - contains a boxed enum for any of the above
+ WithPath(VariantPathRowBuilder<'a>),
+}
+
+impl<'a> VariantToArrowRowBuilder<'a> {
+ pub fn append_null(&mut self) -> Result<()> {
+ use VariantToArrowRowBuilder::*;
+ match self {
+ Int8(b) => b.append_null(),
+ Int16(b) => b.append_null(),
+ Int32(b) => b.append_null(),
+ Int64(b) => b.append_null(),
+ Float16(b) => b.append_null(),
+ Float32(b) => b.append_null(),
+ Float64(b) => b.append_null(),
+ BinaryVariant(b) => b.append_null(),
+ WithPath(path_builder) => path_builder.append_null(),
+ }
+ }
+
+ pub fn append_value(&mut self, value: &Variant<'_, '_>) -> Result<bool> {
+ use VariantToArrowRowBuilder::*;
+ match self {
+ Int8(b) => b.append_value(value),
+ Int16(b) => b.append_value(value),
+ Int32(b) => b.append_value(value),
+ Int64(b) => b.append_value(value),
+ Float16(b) => b.append_value(value),
+ Float32(b) => b.append_value(value),
+ Float64(b) => b.append_value(value),
+ BinaryVariant(b) => b.append_value(value),
+ WithPath(path_builder) => path_builder.append_value(value),
+ }
+ }
+
+ pub fn finish(&mut self) -> Result<ArrayRef> {
+ use VariantToArrowRowBuilder::*;
+ match self {
+ Int8(b) => b.finish(),
+ Int16(b) => b.finish(),
+ Int32(b) => b.finish(),
+ Int64(b) => b.finish(),
+ Float16(b) => b.finish(),
+ Float32(b) => b.finish(),
+ Float64(b) => b.finish(),
+ BinaryVariant(b) => b.finish(),
+ WithPath(path_builder) => path_builder.finish(),
+ }
+ }
+}
+
pub(crate) fn make_variant_to_arrow_row_builder<'a>(
//metadata: &BinaryViewArray,
path: VariantPath<'a>,
- data_type: Option<&'a datatypes::DataType>,
+ data_type: Option<&'a DataType>,
cast_options: &'a CastOptions,
-) -> Result<Box<dyn VariantToArrowRowBuilder + 'a>> {
Review Comment:
Remioving this Box seems like a good idea to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
