pitrou commented on code in PR #47610:
URL: https://github.com/apache/arrow/pull/47610#discussion_r2367065990
##########
python/pyarrow/_csv.pyx:
##########
@@ -1370,7 +1370,7 @@ cdef class WriteOptions(_Weakrefable):
__slots__ = ()
def __init__(self, *, include_header=None, batch_size=None,
- delimiter=None, quoting_style=None):
+ delimiter=None, quoting_style=None, quoting_header=None):
Review Comment:
You'll need to add a doc for the new argument in the class docstring above
as well.
##########
python/pyarrow/_csv.pyx:
##########
@@ -1433,6 +1435,17 @@ cdef class WriteOptions(_Weakrefable):
def quoting_style(self, value):
deref(self.options).quoting_style = unwrap_quoting_style(value)
+ @property
+ def quoting_header(self):
+ """
+ Same as quoting_style, but for header column names
Review Comment:
I think we should add the note that is found in the [C++
docs](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/cpp/src/arrow/csv/options.h#L212-L215),
as otherwise people may be surprised by the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
