rok commented on issue #47613: URL: https://github.com/apache/arrow/issues/47613#issuecomment-3318194375
I'm looking at the [`SparseCSFIndex::Make`](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/cpp/src/arrow/sparse_tensor.cc#L364) and it will make `std::vector<std::shared_ptr<Buffer>>& indptr_data` with a single integer type. However one could construct a `CSFIndex` directly with different integer types as you're suggesting. We could add a check for this in [`CheckSparseCSFIndexValidity` ](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/cpp/src/arrow/sparse_tensor.cc#L340) so [constructor](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/cpp/src/arrow/sparse_tensor.cc#L396) and [`SparseCSFIndex::Make`](https://github.com/apache/arrow/blob/d803afcc43f5d132506318fd9e162d33b2c3d4cd/cpp/src/arrow/sparse_tensor.cc#L364) would throw an error. Thanks for noticing and explaining @andishgar ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
