alamb commented on code in PR #8407:
URL: https://github.com/apache/arrow-rs/pull/8407#discussion_r2369612357
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2297,27 +2296,27 @@ mod tests {
files
}
+ // Round trip the specified record batch with the specified writer
properties,
+ // to an in-memory file, and validate the arrays using the specified
function.
+ // Returns the in-memory file.
fn roundtrip_opts_with_array_validation<F>(
expected_batch: &RecordBatch,
props: WriterProperties,
validate: F,
- ) -> File
+ ) -> Bytes
Review Comment:
this is the change -- rather than writing to a pile of temp files, instead
write to a pile of in memory temp buffers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
