alamb commented on code in PR #8396:
URL: https://github.com/apache/arrow-rs/pull/8396#discussion_r2369666170


##########
arrow-array/src/types.rs:
##########
@@ -1335,7 +1335,11 @@ pub trait DecimalType:
     fn format_decimal(value: Self::Native, precision: u8, scale: i8) -> String;
 
     /// Validates that `value` contains no more than `precision` decimal digits
-    fn validate_decimal_precision(value: Self::Native, precision: u8) -> 
Result<(), ArrowError>;
+    fn validate_decimal_precision(

Review Comment:
   this is technically a breaking API change as it adds new functions. However, 
I think it is reasonable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to