thisisnic commented on code in PR #47618: URL: https://github.com/apache/arrow/pull/47618#discussion_r2369826771
########## r/R/enums.R: ########## @@ -135,7 +135,9 @@ FileType <- enum("FileType", #' @export #' @rdname enums ParquetVersionType <- enum("ParquetVersionType", - PARQUET_1_0 = 0L, PARQUET_2_4 = 2L, PARQUET_2_6 = 3L + PARQUET_1_0 = 0L, PARQUET_2_4 = 1L, PARQUET_2_6 = 2L, + PARQUET_2_7 = 3L, PARQUET_2_8 = 4L, PARQUET_2_9 = 5L, PARQUET_2_10 = 6L, + PARQUET_2_11 = 7L, PARQUET_2_12 = 8L Review Comment: @jonkeane If we export this enum, does that mean we shouldn't go changing previous values, or that it's actually important to sync up with the C++ values? I'm not confident I fully understand how enums are used here and what matches what. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org