pitrou commented on code in PR #47458:
URL: https://github.com/apache/arrow/pull/47458#discussion_r2372629579
##########
cpp/src/arrow/filesystem/hdfs.cc:
##########
@@ -363,8 +363,12 @@ Result<HdfsOptions> HdfsOptions::FromUri(const Uri& uri) {
options_map.emplace(kv.first, kv.second);
}
+ // Special case host = "default" or "hdfs://default" as stated by #25324.
Review Comment:
Let's make the comment more explanator.
```suggestion
// Special case host = "default" or "hdfs://default" as stated by GH-47560.
// If given the string "default", libhdfs selects the default filesystem
from `core-site.xml`.
```
##########
cpp/src/arrow/filesystem/hdfs.cc:
##########
@@ -363,8 +363,12 @@ Result<HdfsOptions> HdfsOptions::FromUri(const Uri& uri) {
options_map.emplace(kv.first, kv.second);
}
+ // Special case host = "default" or "hdfs://default" as stated by #25324.
Review Comment:
Let's make the comment more explanatory.
```suggestion
// Special case host = "default" or "hdfs://default" as stated by GH-47560.
// If given the string "default", libhdfs selects the default filesystem
from `core-site.xml`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
