cyb70289 commented on a change in pull request #9975:
URL: https://github.com/apache/arrow/pull/9975#discussion_r615327919
##########
File path: cpp/src/arrow/util/vector.h
##########
@@ -130,7 +130,7 @@ Result<std::vector<T>>
UnwrapOrRaise(std::vector<Result<T>>&& results) {
}
out.push_back(it->MoveValueUnsafe());
}
- return out;
+ return std::move(out);
Review comment:
@westonpace , also change line 95? And maybe tweak commit message a bit?
I do see `return std::move(local_obj)` is used extensively when returning
`Result` in other source files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
