HuaHuaY commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r2384813548
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -69,9 +69,10 @@
#include "parquet/arrow/schema.h"
#include "parquet/arrow/test_util.h"
#include "parquet/arrow/writer.h"
+#include "parquet/bloom_filter.h"
+#include "parquet/bloom_filter_reader.h"
Review Comment:
```suggestion
```
##########
cpp/src/parquet/xxhasher.h:
##########
@@ -34,6 +34,7 @@ class PARQUET_EXPORT XxHasher : public Hasher {
uint64_t Hash(const Int96* value) const override;
uint64_t Hash(const ByteArray* value) const override;
uint64_t Hash(const FLBA* val, uint32_t len) const override;
+ uint64_t Hash(std::string_view value) const override;
Review Comment:
When will we call this overload function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
