kou commented on code in PR #47627:
URL: https://github.com/apache/arrow/pull/47627#discussion_r2389590360
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -231,6 +231,17 @@ foreach(LIB_TARGET ${ARROW_FLIGHT_LIBRARIES})
target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_FLIGHT_EXPORTING)
endforeach()
+# Handle Unity build header conflicts on Windows
Review Comment:
Can I see the error log?
How about `#include
<arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/platform.h>` in
all `arrow/flight/sql/odbc/**.cc` instead?
##########
ci/scripts/python_wheel_windows_build.bat:
##########
@@ -60,7 +60,7 @@ set CMAKE_GENERATOR=Visual Studio 17 2022
set CMAKE_PLATFORM=x64
set VCPKG_ROOT=C:\vcpkg
set VCPKG_FEATURE_FLAGS=-manifests
-set VCGPK_TARGET_TRIPLET=amd64-windows-static-md-%CMAKE_BUILD_TYPE%
+set VCPKG_TARGET_TRIPLET=amd64-windows-static-md-%CMAKE_BUILD_TYPE%
Review Comment:
GPK!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
