jecsand838 commented on code in PR #8492:
URL: https://github.com/apache/arrow-rs/pull/8492#discussion_r2389946087
##########
arrow-avro/src/schema.rs:
##########
@@ -59,21 +60,13 @@ pub const AVRO_DOC_METADATA_KEY: &str = "avro.doc";
/// Default name for the root record in an Avro schema.
pub const AVRO_ROOT_RECORD_DEFAULT_NAME: &str = "topLevelRecord";
-/// Compare two Avro schemas for equality (identical schemas).
-/// Returns true if the schemas have the same parsing canonical form (i.e.,
logically identical).
-pub fn compare_schemas(writer: &Schema, reader: &Schema) -> Result<bool,
ArrowError> {
- let canon_writer = AvroSchema::generate_canonical_form(writer)?;
- let canon_reader = AvroSchema::generate_canonical_form(reader)?;
- Ok(canon_writer == canon_reader)
-}
-
/// Avro types are not nullable, with nullability instead encoded as a union
/// where one of the variants is the null type.
///
/// To accommodate this, we specially case two-variant unions where one of the
/// variants is the null type, and use this to derive arrow's notion of
nullability
#[derive(Debug, Copy, Clone, PartialEq, Default)]
-pub enum Nullability {
+pub(crate) enum Nullability {
Review Comment:
I made all of these `pub(crate)` to tighten the public API. There's really
no benefit for now for them to be used external to the crate. The idea is to
have `AvroSchema` act as our public schema interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
