lilianm commented on code in PR #8527:
URL: https://github.com/apache/arrow-rs/pull/8527#discussion_r2397683033
##########
parquet/src/column/writer/mod.rs:
##########
@@ -1073,6 +1073,7 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
if let Some(ref mut cmpr) = self.compressor {
let mut compressed_buf =
Vec::with_capacity(uncompressed_size);
cmpr.compress(&buffer[..], &mut compressed_buf)?;
+ compressed_buf.shrink_to_fit();
Review Comment:
I think it's not possible to disable compression on the fly with page v1
https://github.com/apache/parquet-format/blob/9fd57b59e0ce1a82a69237dcf8977d3e72a2965d/src/main/thrift/parquet.thrift#L671-L692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
