alamb commented on issue #8534: URL: https://github.com/apache/arrow-rs/issues/8534#issuecomment-3361456784
> This BufWriter is not flushed() when ArrowWriter<W>::flush() is called. FWIW this should probably be fixed regardless (the inner writer should call flush) > Thanks Andrew. If you could just point me to the place where I can document it I will submit PR. I think it should be documented here: https://github.com/apache/arrow-rs/blob/06c638fa2fcaf9259d6cee5e6f9cf1af57345801/parquet/src/file/writer.rs#L48-L50 As well as `TrackedWrite::new` And any places that create a TrackedWriter, such as https://github.com/apache/arrow-rs/blob/06c638fa2fcaf9259d6cee5e6f9cf1af57345801/parquet/src/file/writer.rs#L187-L186 BTW another reason to avoid adding a BufWriter is if the caller is already using buffered writing (for example writing into a memory buffer) buffering the writes is entirely a waste -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
