alamb commented on code in PR #8540:
URL: https://github.com/apache/arrow-rs/pull/8540#discussion_r2399890054
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -972,9 +975,20 @@ fn canonicalize_and_verify_data_type(
UInt8 | UInt16 | UInt32 | UInt64 | Float16 => fail!(),
// Most decimal types are allowed, with restrictions on precision and
scale
- Decimal32(p, s) if is_valid_variant_decimal(p, s, 9) => borrow!(),
- Decimal64(p, s) if is_valid_variant_decimal(p, s, 18) => borrow!(),
- Decimal128(p, s) if is_valid_variant_decimal(p, s, 38) => borrow!(),
+ //
+ // NOTE: arrow-parquet reads widens 32- and 64-bit decimals to
128-bit, but the variant spec
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
