alinaliBQ commented on code in PR #47680:
URL: https://github.com/apache/arrow/pull/47680#discussion_r2400262578
##########
cpp/src/arrow/flight/sql/odbc/flight_sql/utils_test.cc:
##########
@@ -27,6 +28,13 @@
namespace driver {
namespace flight_sql {
+class UtilTestsWithCompute : public ::testing::Test {
+ public:
+ // This must be done before using the compute kernels in order to
+ // register them to the FunctionRegistry.
+ void SetUp() override { ASSERT_OK(arrow::compute::Initialize()); }
Review Comment:
Yea it's a fair point. I have switched to use `::testing::Environment`
instead
##########
cpp/src/arrow/flight/sql/odbc/flight_sql/CMakeLists.txt:
##########
@@ -99,10 +99,12 @@ if(WIN32)
system_dsn.cc)
endif()
-target_link_libraries(arrow_odbc_spi_impl PUBLIC odbcabstraction
arrow_flight_sql_shared)
+target_link_libraries(arrow_odbc_spi_impl PUBLIC odbcabstraction
arrow_flight_sql_shared
+ arrow_compute_shared
Boost::locale)
-if(MSVC)
- target_link_libraries(arrow_odbc_spi_impl PUBLIC Boost::locale)
+# Link libraries on MINGW64 only
Review Comment:
Good catch, fixed
##########
cpp/src/arrow/flight/sql/odbc/flight_sql/CMakeLists.txt:
##########
@@ -99,10 +99,12 @@ if(WIN32)
system_dsn.cc)
endif()
-target_link_libraries(arrow_odbc_spi_impl PUBLIC odbcabstraction
arrow_flight_sql_shared)
+target_link_libraries(arrow_odbc_spi_impl PUBLIC odbcabstraction
arrow_flight_sql_shared
+ arrow_compute_shared
Boost::locale)
-if(MSVC)
- target_link_libraries(arrow_odbc_spi_impl PUBLIC Boost::locale)
+# Link libraries on MINGW64 only
+if((MINGW AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU") OR APPLE)
Review Comment:
I think it is not needed. Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
