tobixdev commented on PR #8543: URL: https://github.com/apache/arrow-rs/pull/8543#issuecomment-3365457001
@jhorstmann Thanks for your input. That was a flaw in my benchmarks you're right. I've adapted them to now use a `Box<dyn Iterator>`, such that we can hide the "iterator type information" from the compiler (at least I think). I think this also better captures the use case. I really like the idea of re-using `BooleanBuilder`. However, collecting to a `Vec` and then using `from_trusted_len_iter` is more efficient on my machine at least (at the cost of allocating a `Vec`). What if we move this into the `Extend` implementation of the `BooleanBuilder`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
