dangotbanned commented on code in PR #47609: URL: https://github.com/apache/arrow/pull/47609#discussion_r2426793935
########## python/pyproject.toml: ########## @@ -83,11 +83,61 @@ include = ["pyarrow"] namespaces = false [tool.setuptools.package-data] -pyarrow = ["*.pxd", "*.pyx", "includes/*.pxd"] +pyarrow = ["*.pxd", "*.pyx", "includes/*.pxd", "py.typed"] [tool.setuptools_scm] root = '..' version_file = 'pyarrow/_generated_version.py' version_scheme = 'guess-next-dev' git_describe_command = 'git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"' fallback_version = '22.0.0a0' + +[tool.mypy] +files = ["pyarrow"] +exclude = 'pyarrow/interchange/.*|pyarrow/vendored/.*' +mypy_path = "$MYPY_CONFIG_FILE_DIR/pyarrow-stubs" + +[tool.pyright] +include = ["pyarrow"] Review Comment: I guess my advice would be: 1. Try changing your config to **only** `typeCheckingMode = "basic"` 2. Set some threshold for the minimum number of times each rule can be triggered before fixing them all becomes unbearable 3. Fix everything below that threshold 4. Bump up the threshold, rinse/repeat That kind of workflow means you usually fix similar issues at the same time, and don't need to spend as long trying to understand what the error even means 😂 You can also gradually enable/disable subpackages with the `include`, `ignore`, `exclude` filters if you need more control -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
