heymind commented on a change in pull request #10066:
URL: https://github.com/apache/arrow/pull/10066#discussion_r615545715
##########
File path: rust/datafusion/src/datasource/csv.rs
##########
@@ -142,3 +143,142 @@ impl TableProvider for CsvFile {
self.statistics.clone()
}
}
+/// Loads CSV data from a reader
+pub struct CsvRead<R: Read> {
Review comment:
Okay. Would you mind to introduce another dependency crate `either` ?
It's more clear than introducing a new enum.
```rs
pub struct CsvFile {
source: Either<Box<dyn Read>,String>,
....
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
