lidavidm commented on code in PR #3579:
URL: https://github.com/apache/arrow-adbc/pull/3579#discussion_r2434844649
##########
c/driver/postgresql/postgresql_test.cc:
##########
@@ -947,7 +947,90 @@ class PostgresStatementTest : public ::testing::Test,
void TearDown() override { ASSERT_NO_FATAL_FAILURE(TearDownTest()); }
void TestSqlPrepareErrorParamCountMismatch() { GTEST_SKIP() << "Not yet
implemented"; }
- void TestSqlPrepareGetParameterSchema() { GTEST_SKIP() << "Not yet
implemented"; }
+
+ void TestSqlPrepareGetParameterSchema() {
Review Comment:
You should be able to just remove the line and let the base class's test run.
##########
c/driver/postgresql/statement.cc:
##########
@@ -762,7 +762,24 @@ AdbcStatusCode PostgresStatement::GetOptionInt(const char*
key, int64_t* value,
AdbcStatusCode PostgresStatement::GetParameterSchema(struct ArrowSchema*
schema,
struct AdbcError* error) {
- return ADBC_STATUS_NOT_IMPLEMENTED;
+ if (query_.empty()) {
+ InternalAdbcSetError(error, "%s",
+ "[libpq] Must SetSqlQuery before GetParameterSchema");
Review Comment:
```suggestion
InternalAdbcSetError(error, "[libpq] Must SetSqlQuery before
GetParameterSchema");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
